Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Solana address linking #2280

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Implement Solana address linking #2280

merged 7 commits into from
Jan 9, 2024

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Jan 8, 2024 •
edited
Loading

Summary

This PR allows users to link a Solana address to their Brave rewards wallet.

For full details please see the linking flow section in the spec which is attached to the issue

resolves #165

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@clD11 clD11 self-assigned this Jan 8, 2024
pavelbrm
pavelbrm reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive and good work, overall. 👍

Most of the feedback is minor, but some is major. Not approving yet, until the PR is out of draft.

Have got not much to say regarding the business logic. I've read the spec, and it seems like what I've seen has covered it.

Happy to do another round when it's time. 🙂

docker-compose.dev-refresh.yml Outdated Show resolved Hide resolved
libs/wallet/wallet.go Outdated Show resolved Hide resolved
libs/wallet/wallet.go Outdated Show resolved Hide resolved
libs/wallet/wallet.go Outdated Show resolved Hide resolved
libs/wallet/wallet.go Outdated Show resolved Hide resolved
services/wallet/storage/storage_test.go Outdated Show resolved Hide resolved
services/wallet/storage/storage_test.go Outdated Show resolved Hide resolved
services/wallet/storage/storage_test.go Outdated Show resolved Hide resolved
services/wallet/storage/storage_test.go Outdated Show resolved Hide resolved
libs/wallet/wallet_test.go Outdated Show resolved Hide resolved
kdenhartog
kdenhartog reviewed Jan 9, 2024
View reviewed changes
services/wallet/controllers_v3.go Show resolved Hide resolved
services/wallet/controllers_v3.go Outdated Show resolved Hide resolved
docker-compose.dev-refresh.yml Outdated Show resolved Hide resolved
services/wallet/controller_v3_test.go Show resolved Hide resolved
services/wallet/controllers_v3.go Show resolved Hide resolved
services/wallet/controllers_v3.go Show resolved Hide resolved
services/wallet/model/model.go Outdated Show resolved Hide resolved
libs/wallet/wallet.go Show resolved Hide resolved
services/wallet/service.go Show resolved Hide resolved
kdenhartog
kdenhartog approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading through all my comments, nothing seemed like a blocking concern so approving now

@clD11 clD11 marked this pull request as ready for review January 9, 2024 17:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

The following commits were not verified:
124ea1f (unsigned)
b2c704b (unsigned)
c266018 (unsigned)
2218e8b (unsigned)
89c692e (unsigned)
9e00cef (unsigned)
1e5abfe (unsigned)

@clD11 clD11 merged commit ac49405 into master Jan 9, 2024
10 checks passed
@clD11 clD11 deleted the sop-addr-link branch January 9, 2024 19:36
@clD11 clD11 mentioned this pull request Jan 9, 2024
Merged
@clD11 clD11 changed the title feat: implement solana address linking Implement Solana address linking Jan 9, 2024
@hspencer77 hspencer77 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcaller bcaller bcaller left review comments

@pavelbrm pavelbrm pavelbrm left review comments

@kdenhartog kdenhartog kdenhartog approved these changes

@husobee husobee Awaiting requested review from husobee

Assignees

@clD11 clD11

Labels
unverified-commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clD11 @pavelbrm @bcaller @kdenhartog