Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "multiple device refresh improvements" #2329

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Feb 2, 2024

Reverts #2281

@husobee husobee self-assigned this Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

[puLL-Merge] - brave-intl/bat-go@2329

Description

This pull request modifies the services/skus/controllers.go, services/skus/credentials.go, services/skus/datastore.go, services/skus/datastore_test.go, services/skus/instrumented_datastore.go, services/skus/mockdatastore.go, and services/skus/order.go files in the repository.

Changes

Changes

  • Removed the deleteItemCreds() function from the services/skus/controllers.go file.
  • Removed the errExceededMaxActiveOrderCreds constant from the services/skus/credentials.go file.
  • Modified the DeleteOrderCreds function signature in the services/skus/credentials.go file to remove the reqID parameter.
  • Updated the usage of the DeleteOrderCreds function in the services/skus/controllers.go file to reflect the signature change.
  • Updated the DeleteTimeLimitedV2OrderCredsByOrderTx function signature in the services/skus/datastore.go file to match the new parameter list.
  • Removed the DeleteTimeLimitedV2OrderCredsByOrderTx function from the services/skus/mockdatastore.go file.
  • Modified the RenewOrder function in the services/skus/order.go file to reflect the signature change of DeleteOrderCreds function usage.

Security Hotspots

  • There are no security hotspots introduced by these changes.

@husobee husobee enabled auto-merge (squash) February 2, 2024 20:59
@husobee husobee merged commit 6b09228 into master Feb 2, 2024
12 checks passed
@husobee husobee deleted the revert-2281-multi-device-improvements branch February 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants