Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return order_id instead of id in json #2334

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: return order_id instead of id in json #2334

merged 1 commit into from
Feb 6, 2024

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented Feb 6, 2024 •
edited
Loading

Summary

Subj.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm self-assigned this Feb 6, 2024
@pavelbrm pavelbrm marked this pull request as ready for review February 6, 2024 00:53
SergeyZhukovsky
SergeyZhukovsky approved these changes Feb 6, 2024
View reviewed changes
Copy link

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@pavelbrm pavelbrm merged commit 21d0bec into master Feb 6, 2024
19 checks passed
@pavelbrm pavelbrm deleted the fix-response-format branch February 6, 2024 01:10
@pavelbrm pavelbrm mentioned this pull request Feb 6, 2024
Merged
@hspencer77 hspencer77 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@Sneagan Sneagan Sneagan approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

@husobee husobee Awaiting requested review from husobee

@clD11 clD11 Awaiting requested review from clD11

Assignees

@pavelbrm pavelbrm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelbrm @Brandon-T @Sneagan @SergeyZhukovsky