Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix query to check for request id conflict case (mismatch) #2344

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix query to check for request id conflict case (mismatch) #2344

merged 1 commit into from
Feb 6, 2024

Conversation

evq
Copy link
Contributor

@evq evq commented Feb 6, 2024

Summary

This is a fix for #2331, when a request id is accidentally re-used - the request id will be present with a different set of credentials than the ones in the attempted submission.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@evq evq requested review from pavelbrm, husobee and clD11 February 6, 2024 19:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

The following commits were not verified:
bf9a6d9 (unsigned)

@evq evq merged commit e0b3c24 into master Feb 6, 2024
12 checks passed
@evq evq deleted the fix-submit-req-id-mismatch-check branch February 6, 2024 20:03
@evq evq mentioned this pull request Feb 6, 2024
Merged
18 tasks
@pavelbrm pavelbrm changed the title fix query to check for request id conflict case ( mismatch ) fix query to check for request id conflict case (mismatch) Feb 14, 2024
@hspencer77 hspencer77 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clD11 clD11 clD11 approved these changes

@husobee husobee husobee approved these changes

@pavelbrm pavelbrm pavelbrm approved these changes

Assignees

@evq evq

Labels
unverified-commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evq @pavelbrm @husobee @clD11