Production 2024-05-30_01 #2538
Merged
Production 2024-05-30_01 #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavelbrm
commented
May 29, 2024
pavelbrm
commented
- feat: change request_id to disallow null and update index #2506
- feat: check existing creds by number of batches #2522
- feat: delete tlv2 creds with req_id matching item_id #2524
- feat: expose endpoint for checking currently active sets of tlv2 creds #2528
* feat: change request_id to disallow null and change index * test: fix up broken tests * test: fix up other tests
* feat: change request_id to disallow null and change index * test: fix up broken tests * test: fix up other tests * fix: reimplement tlv2 submission reporting * test: change to kick off CI * fix: replace AreTimeLimitedV2CredsSubmitted nonsense with GetCredSubmissionReport * feat: check number of batches * feat: take limit into account when inserting tlv2 * test: trigger ci * fix: check tx error
* feat: change request_id to disallow null and change index * test: fix up broken tests * test: fix up other tests * fix: reimplement tlv2 submission reporting * test: change to kick off CI * fix: replace AreTimeLimitedV2CredsSubmitted nonsense with GetCredSubmissionReport * feat: check number of batches * feat: delete only tlv2 creds with req_id matching item_id * test: fix some broken tests * feat: take limit into account when inserting tlv2 * test: trigger ci * fix: check tx error
#2528) * feat: change request_id to disallow null and change index * test: fix up broken tests * test: fix up other tests * fix: reimplement tlv2 submission reporting * test: change to kick off CI * fix: replace AreTimeLimitedV2CredsSubmitted nonsense with GetCredSubmissionReport * feat: check number of batches * feat: delete only tlv2 creds with req_id matching item_id * test: fix some broken tests * feat: implement endpoint for fetching num of active cred batches * test: add tests for uniqBatchesTxTime * test: add tests for countbatches * test: fix test after fixing error message * fix: use proper comparison * test: use proper name for test * feat: take limit into account when inserting tlv2 * test: trigger ci * fix: check tx error
DJAndries
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.