Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attach forgotten tlv2 repository #2542

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: attach forgotten tlv2 repository #2542

merged 1 commit into from
May 30, 2024

Conversation

pavelbrm
Copy link
Contributor

Summary

Subj. After releasing to Dev, found that I forgot to attach the TLV2 repository to the service, which resulted in panics.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm self-assigned this May 30, 2024
@pavelbrm pavelbrm marked this pull request as ready for review May 30, 2024 05:01
@pavelbrm pavelbrm merged commit c84e19f into master May 30, 2024
18 checks passed
@pavelbrm pavelbrm deleted the fix-panic branch May 30, 2024 05:32
@pavelbrm pavelbrm mentioned this pull request May 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
@pavelbrm
Merge pull request #2543 from brave-intl/master
c42d793 
fix: attach forgotten tlv2 repository (#2542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evq evq evq approved these changes

Assignees

@pavelbrm pavelbrm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelbrm @evq