Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t reattach tab when using always collapsed vertical tabs #32932

Open
ubalklen opened this issue Sep 12, 2023 · 7 comments
Open

Can’t reattach tab when using always collapsed vertical tabs #32932

ubalklen opened this issue Sep 12, 2023 · 7 comments
Assignees
Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@ubalklen
Copy link

ubalklen commented Sep 12, 2023

Description

When using always collapsed vertical tabs (the ones that do not expand even if you mouse hover over them), it's possible to deattach tabs, but it's not possible to attach them back. This functionality works if tabs are not collapsed.

Steps to Reproduce

  1. Setup Brave to have collapsed vertical tabs that do not automatically expand.
  2. Deattach one tab by dragging it out.
  3. Try to reattach the tab by dragging it in back.

Actual result:

The tab will not be reattached, and some rendering issues happen in the detached tab (page stutters white).

Expected result:

The tab should be reattached to the main window.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.57.62 Chromium: 116.0.5845.180 (Official Build) (64-bit)
Revision 77ae816289bb4557b7e04b3ff2e52d091ab68d66
OS Windows 10 Version 20H2 (Build 19042.2965)

Miscellaneous Information

bug.mp4
@ghost
Copy link

ghost commented Sep 12, 2023

For the drop to work you need to drop it in the place of the first tab, seems like it doesn't work anywhere else.
So it still works, just not the way you would expect it to work.

Recording.2023-09-12.173127.mp4

So, this has to be eventually improved/fixed, so it tabs can be dropped anywhere, and it looks and feels more fluid and smooth.

@sangwoo108

@sangwoo108 sangwoo108 self-assigned this Sep 13, 2023
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. feature/vertical-tabs QA/Yes release-notes/exclude labels Sep 13, 2023
@thisisujjawalbhatia
Copy link

hey @sangwoo108 I think the issue is not still resolved, I would Like to Help in this issue, can I try solving it?

@sangwoo108
Copy link

Hi, @thisisujjawalbhatia . I'd be grateful if you could. I think tabstrip height is not fill the entire scrollable area height.

@ghost
Copy link

ghost commented Jun 27, 2024

This is old bug is causing issues also with Close window when closing last tab, where if you don't re-attach the tabs perfectly, it will create invisible windows, so you can get dozens of invisible windows without knowing and the only way to bring them is by using Bring all tabs to this window.

I used Private windows because Private windows will show the Window count, but it happens on every type of window and when VT are set to minimized/expand on mouseover. This doesn't happen with other modes or HT since they just 'attach' the tab. So if this issue didn't exist, it wouldn't behave like that.

Recording.2024-06-26.203331.mp4

@TEMP-ad
Copy link

TEMP-ad commented Jan 16, 2025

I saw someone creating a duplicate of this issue today, it's been a while so it is time to bump it, since it is the first one reporting this.

Maybe @simonhong or even @jagadeshjai might want to take a look at it and finally fix it? while dropping the tabs at the top is the only workaround and it works fine, it's not the correct behavior and new users who might not know the work around might have a trouble experience about like the today's duplicate issue #43339

@simonhong simonhong assigned simonhong and unassigned sangwoo108 Jan 17, 2025
@kongehund
Copy link

kongehund commented Jan 17, 2025

In case this is helpful - When you shut down your computer without closing all Brave windows: when Brave re-opens after a restart, all invisible windows created will become visible separate windows.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

7 participants