Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty moving tabs between windows when using vertical tabs #43339

Closed
3 of 6 tasks
kongehund opened this issue Jan 16, 2025 · 2 comments
Closed
3 of 6 tasks

Difficulty moving tabs between windows when using vertical tabs #43339

kongehund opened this issue Jan 16, 2025 · 2 comments

Comments

@kongehund
Copy link

Description

When trying to move a tab from one window to another by dragging it with the mouse into the tab area of the other window, it seems very buggy, and only works about ~20% of the time.

Steps to reproduce

  1. Enable "Use vertical tabs" in the "Appearance" settings.
  2. Have two windows of Brave open
  3. Click and drag a tab from the vertical sidebar of one window into the vertical sidebar of the other window

Actual result

When you attempt to move the tab, the new window that was created after click-dragging keeps flashing about two times per second while hovering the vertical tabs bar.

I am not completely sure that this is related, but I notice that when I restart my computer and open Brave, a lot of new windows of New Tabs exist. I hypothesize that one is created for each time the window flashes while dragging, but I have not tested this, nor can I explain why I do not see these windows immediately.

2025-01-16.11-02-55.webm

Expected result

The tab join the window whose vertical tab bar you are hovering, and as long as you are still dragging it, it should behave the same way as if you were dragging a tab that was already in that window.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.73.105 Chromium: 131.0.6778.265 (Official Build) (64-bit)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

I do not wish to install Chrome on my computer, so I have not tested whether this issue occurs in Chrome.

@TEMP-ad
Copy link

TEMP-ad commented Jan 16, 2025

There was an issue filed for this issue long time ago, #32932. So not only you created a duplicate issue, but you would have found a workaround for it.

  1. it has to do with Collapsed VT, it works fine in the expanded mode.
  2. The fix is simple, (as shown in the issue), you need to drop it on top of the VT, it works there, and it will glitch anywhere else.
  3. Once you get used to it, it is not so bad, your memory will remember to do that automatically, yeah, it is better if they fix it, but the dev that was working with VT (other issue) is not with Brave anymore.
  4. Chrome doesn't have Vertical Tabs.

@kongehund
Copy link
Author

There was an issue filed for this issue long time ago, #32932. So not only you created a duplicate issue, but you would have found a workaround for it.

  1. it has to do with Collapsed VT, it works fine in the expanded mode.
  2. The fix is simple, (as shown in the issue), you need to drop it on top of the VT, it works there, and it will glitch anywhere else.
  3. Once you get used to it, it is not so bad, your memory will remember to do that automatically, yeah, it is better if they fix it, but the dev that was working with VT (other issue) is not with Brave anymore.
  4. Chrome doesn't have Vertical Tabs.

Thanks for the reply! For your information, I did make a search for it, but must have missed it when I scrolled through the 193 issues mentioning vertical tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants