Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKUs: if the request id is not present, backfill using item id #21505

Merged
merged 2 commits into from
Jan 11, 2024
Merged

SKUs: if the request id is not present, backfill using item id #21505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9163ae2
SKUs: if the request id is not present, backfill using item id
evq Jan 5, 2024
4ddf464
fix compile
evq Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/skus/browser/rs/lib/src/sdk/credentials/fetch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,11 @@ where
let blinded_creds: Vec<BlindedToken> =
match self.client.get_time_limited_v2_creds(&item.id).await? {
Some(item_creds) => {
// overwrite our request id if one is already present
// overwrite our request id if creds are already present
request_id = match item_creds.request_id {
Some(request_id) => request_id,
None => request_id,
// use the item id as the request id if it was not persisted
None => item_id.to_string(),
};

// are we almost expired
Expand Down