Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable password sync by default #27268

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Jan 17, 2025

DO NOT MERGE YET.
Resolves TBD

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

Chromium major version is behind target branch (131.0.6778.85 vs 132.0.6834.83). Please rebase.

@github-actions github-actions bot added CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch labels Jan 17, 2025
@ShivanKaul ShivanKaul force-pushed the feature/enable-password-sync-by-default branch from 8abd21b to bfe2094 Compare January 17, 2025 15:11
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant