[Svelte]: Update svelte-web to work with Svelte5 #890
+433
−292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallaciousreasoning
requested review from
petemill and
AlanBreck
as code owners
Comment on lines
+55
to
+57
| // TODO: Beg Jacob for help | ||
| return; | ||
|
|
There was a problem hiding this comment.
halp @AlanBreck!
| customElement: false | ||
| customElement: false, | ||
| css: 'injected', | ||
| accessors: true, |
There was a problem hiding this comment.
There's a warning that accessors: true isn't supported in runes mode, which seems odd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal example of the changes we need to support Svelte5 in our web components wrapper
@AlanBreck we probably shouldn't land this until the projects we have which use Svelte are ready for this 😨
Note: At this point Storybook doesn't support Svelte5 either