Fix animations without end keyframe going wacky #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animations using keyframes where the animation length is longer than the last keyframe will cause unexpected behaviour - notably, a continuation of the animation, whereas in-game, the animation simply halts at the last keyframe. This PR fixes it by stopping on the last keyframe after reaching it, instead of trying to interpolate to the first keyframe.
|
|
SuperLlama88888
added a commit
to SuperLlama88888/holoprint
that referenced
this pull request
Jan 17, 2025
Actually an issue with @bridge-core/model-viewer regarding keyframes. I've submitted a PR already: bridge-core/model-viewer#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animations using keyframes where the animation length is longer than the last keyframe will cause unexpected behaviour - notably, a continuation of the animation, whereas in-game, the animation simply halts at the last keyframe.
This PR fixes it by stopping on the last keyframe after reaching it, instead of trying to interpolate to the first keyframe.
Without fix
Notice how each anvil continues growing, past its last keyframe. (The structure block is the only correctly-scaled block at the end, since its last keyframe is the same as the animation length.)
animation.bug.webm
In-game animation
Notice how the animation stops after reaching the last keyframe.
as_intended.webm
Proof of the fix
proof.webm