Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vision #428

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Remove vision #428

wants to merge 21 commits into from

Conversation

seanmcguire12
Copy link
Collaborator

why

  • vision doesn't work very well (at all)

what changed

  • still allow for useVision as a param, but give a warning if it is set to true
  • do not use vision for action verification

test plan

evals

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 1c21a55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@seanmcguire12 seanmcguire12 added act These changes pertain to the act function extract These changes pertain to the extract function observe These changes pertain to the observe function text-extract These changes pertain to text-extract labels Jan 23, 2025
@seanmcguire12 seanmcguire12 requested a review from kamath January 24, 2025 22:45
Copy link
Contributor

@kamath kamath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@@ -0,0 +1,5 @@
---
"@browserbasehq/stagehand": major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoa not a major this is a minor

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro trying to pull a sneaky one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive never been good at changesets 🥴

@@ -363,7 +362,7 @@ You will be given:
2. ${
isUsingAccessibilityTree
? "a hierarchical accessibility tree showing the semantic structure of the page"
: "a numbered list of possible elements or an annotated image of the page"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoa nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
act These changes pertain to the act function extract These changes pertain to the extract function observe These changes pertain to the observe function text-extract These changes pertain to text-extract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants