Rename metric name 'old_current_new' to 'old_new_current' #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Rebase on #152 |
moroten
approved these changes
Nov 3, 2024
This matches the following commit in bb-storage, where the typo was
fixed. This will fix the KLM retention graphs in Grafana.
commit c04246b462b6bc68ae9b111d2024c57db439b0b6
Document how to tune the size of LocalBlobAccess
...
While there, fix a typo in the metric name. It should be named
'old_current_new' to match the implementation, not 'old_new_current'.
stagnation
force-pushed
the
feature/fix-typo-in-metric-name
branch
from
2d146ab to
2cbcece
Compare
moroten
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the following commit in bb-storage, where the typo was fixed. This will fix the KLM retention graphs in Grafana.