Allow ARN to be provided for pipeline signing KMS key #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gion keys to be used
Co-authored-by: paul david <[email protected]>
Co-authored-by: paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alterative approach to #1422 to ensure backwards-compatibility with existing stacks.
Description
Our setup is not compatible with the current stack configuration. We have a KMS key in one AWS account which is shared across multiple accounts to sign and verify pipelines. This approach allows the user to specify an ARN of the KMS key so they may use a key cross-account or even cross-region. Existing behaviour is maintained as the Key ID may be provided using
PipelineSigningKMSKeyIdand the ARN is constructed using the current account and region. Key creation in the stack is also maintained.CHANGELOG
PipelineSigningKMSKeyArnparameter to allow KMS key ARN to be provided.PipelineSigningKMSKeyIdto instead usePipelineSigningKMSKeyArnif provided, and construct ARN only if one is not provided andPipelineSigningKMSKeyIdisCo-authored-by: paul [email protected]