On Windows, do not require redist of vcruntime DLL #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <[email protected]>
|
Happy to accommodate although ComponentizeJS only builds for Wasm currently - can you share some further info on how this works? I'd be uncomfortable landing a build config whose target is not tested in this repo, without understanding more about the use case. |
|
Ah, sorry, this is down to me making an assumption and not checking it with more knowledgeable folks - for some reason I thought ComponentizeJS was a native binary. Closing and sorry for the noise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rancher Desktop folks are looking to bundle some Wasm developer tooling. However, they cannot redistribute the vcruntime DLL on Windows for licensing reasons, and therefore prefer Windows builds in the toolchain to link the CRT statically instead of dynamically.