pulley: Implement the wide-arithmetic proposal #9944
Merged
+157
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few minor instructions/lowerings for the new operations added as part of the wide-arithmetic proposal. These are all part of the "extended" opcode set since they shouldn't be common and if they're performance critical you probably want a native backend instead.
alexcrichton
requested review from
cfallin and
dicej
and removed request for
a team
dicej
reviewed
Jan 7, 2025
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "pulley"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
approved these changes
Jan 9, 2025
pulley/src/lib.rs
Outdated
| @@ -1278,6 +1278,39 @@ macro_rules! for_each_extended_op { | |||
| vfma32x4 = Vfma32x4 { dst: VReg, a: VReg, b: VReg, c: VReg }; | |||
| /// `dst = ieee_fma(a, b, c)` | |||
| vfma64x2 = Vfma64x2 { dst: VReg, a: VReg, b: VReg, c: VReg }; | |||
|
|
|||
| /// `dst_lo:dst_hi = lhs_lo:lhs_hi + rhs_lo:rhs_hi` | |||
There was a problem hiding this comment.
maybe a style thing, or Verilog influence, or something, but usually I write a:b concat syntax MSB-first (as the concrete values would be written) -- so dst_hi:dst_lo = ... maybe?
There was a problem hiding this comment.
It's ok I have no influence so I think I swap lo:hi every time I write it, happy to canonicalize to hi:lo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few minor instructions/lowerings for the new operations added as part of the wide-arithmetic proposal. These are all part of the "extended" opcode set since they shouldn't be common and if they're performance critical you probably want a native backend instead.