Make module validation deterministic in case of multiple errors #9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weigelt
requested review from
alexcrichton
and removed request for
a team
github-actions
bot
added
the
wasmtime:api
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Jan 8, 2025
Inspired by bytecodealliance/wasmtime#9947 this helps keep the output of `wasm-tools validate` more deterministic by ensuring that the first error is reported instead of any error within a module.
github-merge-queue bot
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Jan 8, 2025
Inspired by bytecodealliance/wasmtime#9947 this helps keep the output of `wasm-tools validate` more deterministic by ensuring that the first error is reported instead of any error within a module.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Ah the timeout there looks like the new |
|
er, actually, |
added 2 commits
January 9, 2025 08:37
|
@alexcrichton done, and I made the test smaller too. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Wasm binary is invalid in several ways, parallel compilation will return a non-deterministic result. We would like to get a deterministic result even in the presence of multiple errors.
This PR addresses that by first materializing all validation results and then returning the first error, if any ('first' with regard to the order of the input vector).
The downside is that we cannot return early when an error is encountered. This slows down the validation for invalid binaries. Since that is not the happy path anyway, I propose to accept the slowdown.
The provided test does not prove determinism, which is hard to do. But it gives some confidence and ensures the behaviours of parallel and sequential compilation do not deviate.