Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: process instance pdk api enhancement #4847

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat: process instance pdk api enhancement #4847

merged 1 commit into from
Jan 14, 2025

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva commented Dec 11, 2024 •
edited
Loading

@yanavasileva yanavasileva added ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. labels Dec 11, 2024
@yanavasileva yanavasileva self-assigned this Dec 11, 2024
@yanavasileva yanavasileva mentioned this pull request Dec 12, 2024
Open
1 task
@yanavasileva yanavasileva changed the title CI: issue 4049 process instance pdk api enhancement feat: process instance pdk api enhancement Dec 12, 2024
@yanavasileva
Copy link
Member Author

To reviewer:

  • I have already reviewed the community member commits. Please review only my commits.

@yanavasileva yanavasileva mentioned this pull request Dec 12, 2024
Closed
@yanavasileva yanavasileva marked this pull request as ready for review December 12, 2024 07:45
yanavasileva
yanavasileva commented Dec 12, 2024
View reviewed changes
engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/ExecutionEntity.java
@@ -774,9 +783,13 @@ public void setProcessDefinition(ProcessDefinitionImpl processDefinition) {
this.processDefinition = processDefinition;
if (processDefinition != null) {
this.processDefinitionId = processDefinition.getId();
if (processDefinition instanceof ProcessDefinitionEntity) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📓 Process definition can be created without a key. Therefore, setting the key only if we have have it.
Found out about the use case via failing org.camunda.bpm.engine.test.standalone.entity.EntitySerializationTest.testExecutionEntitySerialization().

@Nandanrshenoy
Copy link
Contributor

@yanavasileva ,
Is there some thing that I can take up to conclude this contribution.If so please suggest.Thanks.

Nandan

mboskamp
mboskamp approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@mboskamp mboskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good in general, I added one comment but otherwise I think this is good to go.

engine/src/main/java/org/camunda/bpm/engine/runtime/ProcessInstance.java Outdated Show resolved Hide resolved
@mboskamp
Copy link
Member

mboskamp commented Jan 8, 2025

Sorry, I accidentally pushed a commit to this branch. I reverted it. Please squash when merging.

@Nandanrshenoy
Copy link
Contributor

Thanks to each one of you for your support.If there is any action item at my end kindly flag me.

Regards,
Nandan Shenoy

@yanavasileva yanavasileva added ci:no-build Prevents any CI stage from running. and removed ci:no-build Prevents any CI stage from running. labels Jan 10, 2025
@yanavasileva
Copy link
Member Author

Rebase before merge:

@yanavasileva yanavasileva force-pushed the fidelity-contributions-feature/git-issue-4049-process-instance-pdk-api-enhancement branch from 585aa2a to 038ac1b Compare January 14, 2025 11:52
@yanavasileva yanavasileva merged commit efdc8c8 into master Jan 14, 2025
5 of 6 checks passed
@yanavasileva yanavasileva deleted the fidelity-contributions-feature/git-issue-4049-process-instance-pdk-api-enhancement branch January 14, 2025 16:51
@yanavasileva yanavasileva mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboskamp mboskamp mboskamp approved these changes

Assignees

@yanavasileva yanavasileva

Labels
ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanavasileva @Nandanrshenoy @mboskamp