Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(wildfly): upgrade to wildfly 35 #4863

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PHWaechtler
Copy link
Contributor

@PHWaechtler PHWaechtler commented Dec 19, 2024

related to #4655

Description

Adds support for wildfly 35

Keeping track of license check in this doc

  • License check doc here
  • Manual testing of CE Wildfly 35
  • Manual testing of EE Wildfly 35
  • Manual testing of EE Jboss 8
  • CI green

For manual testing setup, this guide was used.
Follow up: https://github.com/camunda/team-automation-platform/issues/282

@PHWaechtler PHWaechtler self-assigned this Dec 19, 2024
@PHWaechtler PHWaechtler added ci:jbosseap Runs the builds for the JBoss EAP application server. ci:wildfly Runs the builds for the Wildfly application server. bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. labels Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Java dependency diff

Omitted due to character limit. See workflow artifacts for full diff file.

Module details

Omitted due to character limit. See workflow artifacts for full diff file.

Checklist

Unique changes

Unique additions

Developer comments

Glossary

Limitations

  • The reported transitive dependencies may not always be accurate in a multi-module project.
    The SBOM file format represents a unique dependency (coordinates + type) only once. In a multi-module
    project a dependency can be declared in multiple locations with different exclusions of transitive dependencies
    or different version overrides for transitive dependencies.

Emojies

  • ✔: All licenses are on the Go list
  • ⚠: (At least one) license is on the Caution list
  • ❌: (At least one) license is on the Stop list
  • ❓: (At least one) license cannot be determined or is unknown
  • ‼: Dependency has multiple licenses declared
  • ⬆: New dependency version is higher than previous
  • ⬇: New dependency version is lower than previous
  • 🔄: Dependency version is equal and the dependencies of this component changed (e.g. when comparing snapshots)
  • 🤷: The change of the dependency version can not be determined further (e.g. because the version does not follow semantic versioning)

@PHWaechtler PHWaechtler force-pushed the 4655-support-wildfly-35 branch from a6126f2 to 8ce1d36 Compare December 20, 2024 12:53
@PHWaechtler PHWaechtler mentioned this pull request Jan 7, 2025
1 task
@PHWaechtler PHWaechtler force-pushed the 4655-support-wildfly-35 branch from 802d5aa to 24bc0f2 Compare January 9, 2025 08:49
@@ -404,9 +404,10 @@ pipeline {
agentLabel: 'chrome_112',
runSteps: {
cambpmRunMaven('qa/',
'clean install -Pwildfly,h2,webapps-integration',
"clean install -Pwildfly,h2,webapps-integration -pl '!integration-tests-engine-jakarta'",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This CI had to be updated to jdk17, which automatically enabled a profile that adds integration-tests-engine-jakarta'. For now we're excluding it manually here as it interfered with the Wildfly test setup, but I've created https://github.com/camunda/team-automation-platform/issues/282 to reconsider the logic behind this auto profile.

@@ -239,7 +239,7 @@
<plugin>
<groupId>org.codehaus.cargo</groupId>
<artifactId>cargo-maven3-plugin</artifactId>
<version>1.10.9</version>
<version>1.10.16</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I updated cargo to have access to the wildfly35x containerID used in qa/integration-tests-webapps/pom.xml

@PHWaechtler PHWaechtler marked this pull request as ready for review January 9, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. ci:jbosseap Runs the builds for the JBoss EAP application server. ci:wildfly Runs the builds for the Wildfly application server.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant