Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pom): add support for Spring Boot 3.4.1 #4880

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

mboskamp
Copy link
Member

@mboskamp mboskamp commented Jan 6, 2025

Related to #4657

@mboskamp mboskamp added ci:e2e Runs the frontend end-to-end tests. ci:all-as Runs the builds for all application servers. ci:run Runs the integration tests for the Run distribution. ci:spring-boot Runs the integration tests for the Spring Boot starter. labels Jan 6, 2025
@mboskamp mboskamp self-assigned this Jan 6, 2025
@mboskamp mboskamp mentioned this pull request Jan 6, 2025
1 task
@mboskamp mboskamp added the ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). label Jan 6, 2025
@mboskamp mboskamp requested a review from psavidis January 9, 2025 13:46
@mboskamp mboskamp changed the title 4657 spring boot 3.4 chore(pom): add support for Spring Boot 3.4.0 Jan 9, 2025
@mboskamp mboskamp marked this pull request as ready for review January 9, 2025 13:46
@psavidis psavidis added the bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. label Jan 9, 2025
@mboskamp mboskamp changed the title chore(pom): add support for Spring Boot 3.4.0 chore(pom): add support for Spring Boot 3.4.1 Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Java dependency diff

Omitted due to character limit. See workflow artifacts for full diff file.

Module details

Omitted due to character limit. See workflow artifacts for full diff file.

Checklist

Unique changes

Unique additions

  • spring-boot-starter: 3.4.1
  • spring-beans: 6.2.1
  • spring-context: 6.2.1
  • spring-aop: 6.2.1
  • spring-core: 6.2.1
  • spring-jcl: 6.2.1
  • spring-expression: 6.2.1
  • micrometer-observation: 1.14.2
  • micrometer-commons: 1.14.2
  • spring-boot: 3.4.1
  • spring-boot-autoconfigure: 3.4.1
  • spring-boot-starter-logging: 3.4.1
  • logback-classic: 1.5.12 ⚠❓‼
  • logback-core: 1.5.12 ⚠❓‼
  • log4j-to-slf4j: 2.24.3
  • log4j-api: 2.24.3
  • jul-to-slf4j: 2.0.16
  • jakarta.annotation-api: 2.1.1 ⚠‼
  • snakeyaml: 2.3
  • slf4j-api: 2.0.16
  • commons-io: 2.16.1

Developer comments

Glossary

Limitations

  • The reported transitive dependencies may not always be accurate in a multi-module project.
    The SBOM file format represents a unique dependency (coordinates + type) only once. In a multi-module
    project a dependency can be declared in multiple locations with different exclusions of transitive dependencies
    or different version overrides for transitive dependencies.

Emojies

  • ✔: All licenses are on the Go list
  • ⚠: (At least one) license is on the Caution list
  • ❌: (At least one) license is on the Stop list
  • ❓: (At least one) license cannot be determined or is unknown
  • ‼: Dependency has multiple licenses declared
  • ⬆: New dependency version is higher than previous
  • ⬇: New dependency version is lower than previous
  • 🔄: Dependency version is equal and the dependencies of this component changed (e.g. when comparing snapshots)
  • 🤷: The change of the dependency version can not be determined further (e.g. because the version does not follow semantic versioning)

@mboskamp
Copy link
Member Author

mboskamp commented Jan 9, 2025

artifact old license new license output comment ok?
junit EPL 2.0 EPL 2.0 junit-platform-commons: 1.10.5 ⚠ => 1.11.4 ⚠
junit EPL 2.0 EPL 2.0 junit-jupiter-api: 5.10.5 ⚠ => 5.11.4 ⚠
junit EPL 2.0 EPL 2.0 junit-jupiter-params: 5.10.5 ⚠ => 5.11.4 ⚠
junit EPL 2.0 EPL 2.0 junit-platform-engine: 1.10.5 ⚠ => 1.11.4 ⚠
junit EPL 2.0 EPL 2.0 junit-jupiter-engine: 5.10.5 ⚠ => 5.11.4 ⚠
junit EPL 2.0 EPL 2.0 junit-jupiter: 5.10.5 ⚠ => 5.11.4 ⚠
hibernate LGPL 2.1 LGPL 2.1 hibernate-core: 6.5.3.Final ❓ => 6.6.4.Final ❓
jersey EPL 2.0 EPL 2.0 jersey-bean-validation: 3.1.9 ⚠❓‼ => 3.1.9 ⚠❓‼
jersey EPL 2.0 EPL 2.0 jersey-media-json-jackson: 3.1.9 ⚠❓‼ => 3.1.9 ⚠❓‼
logback LGPL 2.1 LGPL 2.1 logback-classic: 1.5.12 ⚠❓‼ not a new library
logback LGPL 2.1 LGPL 2.1 logback-core: 1.5.12 ⚠❓‼ not a new library
jakarta EPL 2.0 EPL 2.0 jakarta.annotation-api: 2.1.1 ⚠‼ not a new library

Some of the libraries above are reported as new additions. But this is false; we have used and shipped them in previous Spring Boot environments.

@psavidis
Copy link
Contributor

psavidis commented Jan 9, 2025

Reviewer Notes

  • License check and CI passed successfully ✔️
  • After the latest bump, camunda-run is updated to use spring boot 3.4.1 (see screenshot)
    • relevant to task for bumping the spring boot version of camunda-run

@mboskamp mboskamp merged commit 7e1813e into master Jan 10, 2025
6 of 7 checks passed
@mboskamp mboskamp deleted the 4657-spring-boot-3.4 branch January 10, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. ci:all-as Runs the builds for all application servers. ci:e2e Runs the frontend end-to-end tests. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:run Runs the integration tests for the Run distribution. ci:spring-boot Runs the integration tests for the Spring Boot starter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants