feat(rest): make LockAndFetchHandler blocking queue's capacity configurable #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquinfelici
added
ci:all-as
1 task
joaquinfelici
force-pushed
the
4885-LockAndFetchQSize
branch
3 times, most recently
from
23c3e23 to
c052fd3
Compare
joaquinfelici
commented
Jan 16, 2025
| throw new NumberFormatException("Parameter " + BLOCKING_QUEUE_CAPACITY_PARAM_NAME + " has to be greater than zero"); | ||
| } | ||
| capacity = parsedCapacity; | ||
| } catch (NumberFormatException e) { |
There was a problem hiding this comment.
This will catch both exceptions thrown:
- By
Integer.parseInt()(if it's not parseable int). - By custom throw above in case it's
<= 0.
…urable Related to #4885
joaquinfelici
force-pushed
the
4885-LockAndFetchQSize
branch
from
c052fd3 to
39fb9de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4885