[DPE-5964] - TLS certificate renewal #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # write certificates to disk | ||
| self.charm.tls_manager.write_certificate(cert, private_key) | ||
|
|
||
| # Updating certificates no need to do a rolling restart | ||
| if self.charm.state.unit_server.tls_state == TLSState.TLS: |
There was a problem hiding this comment.
what of the case where the peer-cert was issued but this hook was invoked for the client-cert? what would the state of tls be?
| if self.charm.state.unit_server.certs_ready: | ||
| self.charm.set_status(Status.TLS_NOT_READY) |
There was a problem hiding this comment.
Left a comment on the other PR about this
| # check if all units have been added to the cluster | ||
| endpoints = get_cluster_endpoints(ops_test, APP_NAME, tls_enabled=True) | ||
| leader_unit = await get_juju_leader_unit_name(ops_test, APP_NAME) | ||
| assert leader_unit |
There was a problem hiding this comment.
was there a case when this was false?
|
|
||
| # make sure data can be written to the cluster | ||
| secret = await get_secret_by_label(ops_test, label=f"{PEER_RELATION}.{APP_NAME}.app") | ||
| assert secret |
There was a problem hiding this comment.
please add messages to your assertion for when they fail.
e.g
assert secret, f"Secret: {PEER_RELATION}.{APP_NAME}.app" missing.
| # wait for certificate to expire | ||
| logger.info(f"Waiting for the certificate to expire {EXPIRATION_WAITING_TIME}s") | ||
| sleep(EXPIRATION_WAITING_TIME) | ||
|
|
There was a problem hiding this comment.
Can we add a test on the status of the application / units? Does it change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handeled the TLS certificate renewal.
Enhancements to TLS Handling:
Statusenum insrc/literals.pyto update the message forTLS_NOT_READYto "enabling/disabling TLS" for better clarity._on_certificate_availablemethod insrc/events/tls.pyto only write the certificates to disk if TLS has already been enabled.Improvements to Tests:
tests/integration/test_tls.pyto ensure that the leader unit and secrets are correctly retrieved. [1] [2] [3] [4] [5]test_certificate_expirationintests/integration/test_tls.pyto verify that the system correctly handles certificate expiration and renewal.Code Refinements:
tests/integration/helpers.pyto improve code readability and maintainability. [1] [2]CertTypefrommanagers/tlsintests/integration/helpers.pyandtests/integration/test_tls.pyto support the new test case and helper function. [1] [2]Dependency Update:
pydanticversion 2.9.1 to integration dependencies.