Dev/foxglove dashboards #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guillaumebeuzeboc
force-pushed
the
dev/foxglove_dashboards
branch
from
cf247ad to
6db5596
Compare
artivis
requested changes
Feb 21, 2024
cos_registration_server/devices/migrations/0003_device_foxglove_layouts_and_more.py
Outdated
Show resolved
Hide resolved
artivis
reviewed
Feb 21, 2024
| @@ -9,4 +9,9 @@ | |||
| # make a version API url | |||
| path("v1/devices", views.devices, name="devices"), | |||
| path("v1/devices/<str:uid>", views.device, name="device"), | |||
| path( | |||
| "v1/devices/<str:uid>/foxglove_layouts/<str:layout_uid>", | |||
There was a problem hiding this comment.
Wouldn't it be better for the layout_uid to be a query param ? foxglove_layouts/some_name vs foxglove_layouts?layout=some_name.
There was a problem hiding this comment.
No strong opinions but usually path are for resources on the server and parameters for performing action (download a file, connect to a remote, sort, filter).
The stack exchange doc seems to follow that: https://api.stackexchange.com/docs
There was a problem hiding this comment.
My (rough) understanding was that paths are for things that won't change while params are for things that may change (e.g. v1 or devices will never change while the name of a layout may change).
That's why we need to put that on paper ^^
Guillaumebeuzeboc
force-pushed
the
dev/foxglove_dashboards
branch
from
c933bf9 to
92a580e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully tested with Foxglove in ROB COS.