Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnyHttpUrl validator for jenkins's server_url config field #35

Merged

Conversation

Thanhphan1147
Copy link
Collaborator

Applicable spec:

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@Thanhphan1147 Thanhphan1147 added the trivial This is a trivial PR label Nov 8, 2023
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner November 8, 2023 09:57
Copy link
Contributor

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some small comments

src/state.py Outdated Show resolved Hide resolved
src/state.py Outdated Show resolved Hide resolved
src/state.py Outdated Show resolved Hide resolved
@Thanhphan1147 Thanhphan1147 changed the title Add HttpUrl validator for jenkins's server_url config field Add AnyHttpUrl validator for jenkins's server_url config field Nov 9, 2023
src/state.py Outdated Show resolved Hide resolved
@Thanhphan1147 Thanhphan1147 self-assigned this Nov 9, 2023
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unit tests?

@amandahla
Copy link
Contributor

Could you fill in the PR description?

yanksyoon
yanksyoon previously approved these changes Nov 11, 2023
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the changes!

arturo-seijas
arturo-seijas previously approved these changes Nov 14, 2023
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test coverage for 68a610c

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/agent.py        111      0     28      0   100%
src/charm.py         54      0     10      0   100%
src/metadata.py      11      0      0      0   100%
src/pebble.py        20      0      0      0   100%
src/server.py        51      0     12      0   100%
src/state.py         79      0     16      0   100%
-------------------------------------------------------------
TOTAL               326      0     66      0   100%

Static code analysis report

Run started:2023-11-14 17:18:21.225448

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1753
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Thanhphan1147 Thanhphan1147 merged commit f40fdc5 into main Nov 15, 2023
19 checks passed
@Thanhphan1147 Thanhphan1147 deleted the ISD-1287/add_http_url_pydantic_validator_for_charm_config branch November 15, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants