Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename fixtures for clarity #61

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

yanksyoon
Copy link
Collaborator

Applicable spec: N/A

Overview

Follow up to the comment on #58 PR, #58 (review) to rename the fixtures returning the app related to abc charm to abc_related_app from app_abc_related for clarity.
All other fixtures in this codebase use fixture naming convention: abc_related_app to denote Jenkins charm, abc_related to denote abc charm related to Jenkins charm.

Rationale

To follow conventions in this codebase.

Juju Events Changes

None.

Module Changes

None.

Library Changes

None.

Checklist

@yanksyoon yanksyoon added the trivial This is a trivial PR label Nov 15, 2023
@yanksyoon yanksyoon requested a review from a team as a code owner November 15, 2023 09:33
Copy link
Contributor

Test coverage for e09365c

Name               Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------
src/agent.py          91      0     12      0   100%
src/charm.py         107      0     18      0   100%
src/cos.py            21      0      0      0   100%
src/ingress.py         9      0      0      0   100%
src/jenkins.py       355      0     68      0   100%
src/state.py         103      0     22      0   100%
src/status.py          6      0      2      0   100%
src/timerange.py      31      0      6      0   100%
--------------------------------------------------------------
TOTAL                723      0    128      0   100%

Static code analysis report

Run started:2023-11-15 10:05:43.837923

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5584
  Total lines skipped (#nosec): 6
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 86fb692 into main Nov 15, 2023
24 checks passed
@arturo-seijas arturo-seijas deleted the chore/test_rename_fixture_convention branch November 15, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libraries: OK trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants