Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "getting started" docs link #74

Merged
merged 9 commits into from
Jan 3, 2024
Merged

Conversation

jsimpso
Copy link
Contributor

@jsimpso jsimpso commented Dec 4, 2023

Fixes #73

Overview

Fix documentation link.

Rationale

Existing link is oudtdated and 404's.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

Largely N/A, single trivial documentation link update.

@jsimpso jsimpso requested a review from a team as a code owner December 4, 2023 01:05
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yanksyoon
Copy link
Collaborator

/canonical/self-hosted-runners/run-workflows 419389a

Copy link

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanksyoon
Copy link
Collaborator

/canonical/self-hosted-runners/run-workflows cb64b1c

@yanksyoon
Copy link
Collaborator

/canonical/self-hosted-runners/run-workflows bce1401

@yanksyoon
Copy link
Collaborator

/canonical/self-hosted-runners/run-workflows a01860d

@jdkandersson
Copy link
Contributor

@yanksyoon I retriggered the tests, not sure if this should be passing now?

@jdkandersson
Copy link
Contributor

/canonical/self-hosted-runners/run-workflows 01bd5a8

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Test coverage for 01bd5a8

Name               Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------
src/actions.py        29      0      4      0   100%
src/agent.py          93      0     12      0   100%
src/charm.py          91      0     14      0   100%
src/cos.py            21      0      0      0   100%
src/ingress.py         9      0      0      0   100%
src/jenkins.py       323      0     58      0   100%
src/state.py         114      0     26      0   100%
src/timerange.py      31      0      6      0   100%
--------------------------------------------------------------
TOTAL                711      0    120      0   100%

Static code analysis report

Run started:2024-01-03 06:21:20.171418

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5661
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@jdkandersson
Copy link
Contributor

I think we saw the issue of not being able to upload rocks to ghcr.io on other PRs from forks - I don't think there is much we can do. Since it is a change to the readme I'll merge without the checks passing

@jdkandersson jdkandersson merged commit a5b0152 into canonical:main Jan 3, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs link "getting started" is 404
5 participants