Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: applied suggetsions from zhijie-yang in #272 #287

Merged
merged 2 commits into from
Nov 18, 2024
Merged

refactor: applied suggetsions from zhijie-yang in #272 #287

merged 2 commits into from
Nov 18, 2024

Conversation

clay-lake
Copy link
Contributor

@clay-lake clay-lake commented Nov 15, 2024 •
edited
Loading

Features contained in this PR:

@clay-lake clay-lake requested a review from a team as a code owner November 15, 2024 14:45
SamirPS
SamirPS reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@SamirPS SamirPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

linostar
linostar approved these changes Nov 15, 2024
View reviewed changes
Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@clay-lake clay-lake merged commit a65310b into main Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamirPS SamirPS SamirPS left review comments

@linostar linostar linostar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clay-lake @linostar @SamirPS