Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocks 1453 - Reusable test rock workflow #294

Merged
merged 44 commits into from
Nov 29, 2024

Conversation

clay-lake
Copy link
Contributor

@clay-lake clay-lake commented Nov 22, 2024


Feature included in this PR:

  • Reusable Test-Rock Workflow
    • Example reusable workflow run here. Note: Documentation will follow up in a rocks-toolbox PR
  • Vulnerability-Scan Workflow is now only executed by continuous testing cron-job workflow.
  • Additional workflow testing added to self tests to execute Build-Rock, Test-Rock and Vulnerability-Scan

Example run of .github/workflows/Continuous-Testing.yaml with testing mock:

clay-lake and others added 28 commits November 21, 2024 09:38
…rkflow' into ROCKS-1453/reusable_test_rock_workflow
@clay-lake clay-lake marked this pull request as ready for review November 26, 2024 15:44
@clay-lake clay-lake requested a review from a team as a code owner November 26, 2024 15:44
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, but there are some nits to fix.

.github/workflows/Image.yaml Outdated Show resolved Hide resolved
.github/workflows/Image.yaml Outdated Show resolved Hide resolved
.github/workflows/Test-Rock.yaml Outdated Show resolved Hide resolved
.github/workflows/Vulnerability-Scan.yaml Outdated Show resolved Hide resolved
.github/workflows/Vulnerability-Scan.yaml Outdated Show resolved Hide resolved
.github/workflows/Vulnerability-Scan.yaml Outdated Show resolved Hide resolved
.github/workflows/_Test-OCI-Factory.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Seems we need some tests and tries to restore previous indentations.

.github/workflows/Test-Rock.yaml Outdated Show resolved Hide resolved

- name: Process report
if: ${{ !cancelled() }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to test if this also works for calling a reusable workflow in the test-vulnerabilities contains a failed job.

.github/workflows/Vulnerability-Scan.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! Thanks!!

@clay-lake clay-lake merged commit 180d685 into main Nov 29, 2024
@cjdcordeiro cjdcordeiro deleted the ROCKS-1453/reusable_test_rock_workflow branch November 29, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants