-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add valkey to oci-factory #306
Conversation
…fest in the rock image
…est in the rock image
…est in the rock image and updating the valkey version to 7.2.7 and Ubuntu version to 24.04
@zhijie-yang I think we can no longer use our self-hosted runners, according to https://github.com/canonical/oci-factory/actions/runs/12694115078/job/35383511241?pr=306. We'll need to discuss this offline as it will affect arm64 builds. (FYI @reneradoi ) |
Hello @cjdcordeiro I just wanted to update on this topic. Is anything still to be done from my side? I see that one CI step is failing, but I'm not sure if this is related to my PR or to your previous comment. What are the next steps for publishing the image to Dockerhub? |
Hi @reneradoi there isn't yet a fix but I'm trying to apply a patch and change a few settings, even if temporarily, just to get this going |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there's a CVE to be addressed:
'[{"Target":"usr/bin/redis_exporter","LastModifiedDate":"2024-09-09T15:35:07.573Z","VulnerabilityID":"CVE-2024-34156","PkgName":"stdlib","Severity":"HIGH"}]'
If you cannot fix it, then see https://github.com/canonical/oci-factory?tab=readme-ov-file#Vulnerability-Filtering
upgrade the metrics exporter to v1.67.0 and golang-version to 1.23
The vulnerability has been patched now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry for the extra pass, but it would also be good to expand a bit more on the documentation. Here's an example: https://github.com/canonical/oci-factory/blob/main/oci/grafana/documentation.yaml
I've updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyvm for the changes. lgtm ;)
Ping the @canonical/rocks team.
Description
This PR adds the valkey rock to the OCI factory. The onboarding issue can be found here.
Picture of a cool rock: