[DPE-2804] Split off lib-check #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
force-pushed
the
dpe-2804-conditional-lib-check
branch
from
838e10e to
681fcc0
Compare
taurus-forever
approved these changes
Oct 20, 2023
dragomirp
commented
Oct 23, 2023
| name: Check libraries | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| if: ${{ github.event.pull_request.head.repo.full_name == 'canonical/postgresql-k8s-operator' }} |
There was a problem hiding this comment.
If the PR is not from the main repo, skip the check.
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
* Split off lib-check * Don't release lib-check changes * Bump libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Checking charm libs requires credentials that are not available to contributors outside of the DPE team.
Solution
Split the checking action in a separate workflow that is not run on forked PRs.