Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2804] Fix backup condition check #312

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Nov 2, 2023

Issue

Secrets tests were always skipped.

Solution

Secrets tests are only sometimes skipped.

@dragomirp dragomirp marked this pull request as ready for review November 2, 2023 11:29
run: |
if [[ "${{ github.event.pull_request.head.repo.full_name }}" == "canonical/postgresql-k8s-operator" ]]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Var was empty, so always false.

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code is was more K.I.S.S! LGTM.

@dragomirp dragomirp merged commit b49d1f7 into main Nov 3, 2023
35 checks passed
@dragomirp dragomirp deleted the dpe-2804-fix-conditional-backup-tests branch November 3, 2023 07:57
marceloneppel pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
BON4 pushed a commit to BON4/postgresql-k8s-operator that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants