[ADVAPP-1099]: Refactor Notifications to remove Channel traits and allow via to be customized like in traditional Laravel applications #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
added
the
Change Type | Chore
…low via to be customized like in traditional Laravel applications Signed-off-by: Dan Harrin <[email protected]>
danharrin
force-pushed
the
advapp-1099
branch
from
5a6b40e to
1225731
Compare
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
Signed-off-by: Dan Harrin <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Harrin [email protected]
Ticket(s) or GitHub Issue
Technical Description
Refactors notifications to use the traditional Laravel mechanisms for sending. Uses custom channels to implement wrapper logic around the standard notification class and traits. Database-only notifications do not have the
Queueabletrait anymore so do not get queued.Any deployment steps required?
No
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
No
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.