fix: add lodash as a dependency (#2990)

Signed-off-by: Akshat Patel <[email protected]>

package.json

@@ -145,6 +145,7 @@
     "@floating-ui/dom": "1.6.3",
     "@ibm/telemetry-js": "^1.5.0",
     "flatpickr": "4.6.13",
+    "lodash": "4.17.21",
     "tslib": "2.3.0"
   }
 }

src/datepicker/datepicker.component.ts

@@ -241,7 +241,8 @@ export class DatePicker implements
 			dateFormat: this.dateFormat,
 			locale: languages.default?.default[this.language] || languages.default[this.language],
 			// Little trick force "readonly mode" on datepicker input.
-			// Docs: Whether clicking on the input should open the picker. You could disable this if you wish to open the calendar manually with.open().
+			// Docs: Whether clicking on the input should open the picker.
+			// You could disable this if you wish to open the calendar manually with.open().
 			clickOpens: !this.readonly
 		});
 	}

src/ng-package.json

@@ -10,6 +10,7 @@
 		"@carbon/icons",
 		"@floating-ui/dom",
 		"@ibm/telemetry-js",
-		"flatpickr"
+		"flatpickr",
+    "lodash"
 	]
 }

src/package.json

@@ -22,6 +22,7 @@
     "@floating-ui/dom": "1.6.3",
     "@ibm/telemetry-js": "^1.5.0",
     "flatpickr": "4.6.13",
+    "lodash": "4.17.21",
     "tslib": "2.3.0"
   }
 }

src/select/select.component.ts

@@ -137,6 +137,17 @@ import { ControlValueAccessor, NG_VALUE_ACCESSOR } from "@angular/forms";
 	]
 })
 export class Select implements ControlValueAccessor, AfterViewInit {
+	@Input() set value(v) {
+		this._value = v;
+		if (this.select) {
+			this.select.nativeElement.value = this._value;
+		}
+	}
+
+	get value() {
+		return this._value;
+	}
+
 	/**
 	 * Tracks the total number of selects instantiated. Used to generate unique IDs
 	 */
@@ -202,17 +213,6 @@ export class Select implements ControlValueAccessor, AfterViewInit {
 
 	@ViewChild("select") select: ElementRef;
 
-	@Input() set value(v) {
-		this._value = v;
-		if (this.select) {
-			this.select.nativeElement.value = this._value;
-		}
-	}
-
-	get value() {
-		return this._value;
-	}
-
 	protected _value;
 
 	ngAfterViewInit() {
@@ -276,12 +276,6 @@ export class Select implements ControlValueAccessor, AfterViewInit {
 		return value instanceof TemplateRef;
 	}
 
-	/**
-	 * placeholder declarations. Replaced by the functions provided to `registerOnChange` and `registerOnTouched`
-	 */
-	protected onChangeHandler = (_: any) => { };
-	protected onTouchedHandler = () => { };
-
 	onMouseDown(event: MouseEvent) {
 		/**
 		 * This prevents the select from opening with mouse
@@ -301,4 +295,10 @@ export class Select implements ControlValueAccessor, AfterViewInit {
 			event.preventDefault();
 		}
 	}
+
+	/**
+	 * placeholder declarations. Replaced by the functions provided to `registerOnChange` and `registerOnTouched`
+	 */
+	protected onChangeHandler = (_: any) => { };
+	protected onTouchedHandler = () => { };
 }

src/treeview/tree-node.component.ts

@@ -246,7 +246,7 @@ export class TreeNodeComponent implements AfterContentChecked, OnInit, OnDestroy
 	}
 
 	emitFocusEvent(event) {
-		const node = { id: this.id, label: this.label, value: this.value }
+		const node = { id: this.id, label: this.label, value: this.value };
 		this.nodeFocus.emit({ node, event });
 		this.treeViewService.focusNode(node);
 	}

src/treeview/tree-node.types.ts

@@ -7,7 +7,8 @@ export interface Node {
 	id?: string;
 	active?: boolean;
 	disabled?: boolean;
-	// selectable is only valid for nodes with children. If true, the node won't become selected and if clicked it would only expand/compress itself
+	// Selectable is only valid for nodes with children.
+	// If true, the node won't become selected and if clicked it would only expand/compress itself
 	selectable?: boolean;
 	expanded?: boolean;
 	selected?: boolean;

src/treeview/treeview.component.ts

@@ -171,7 +171,7 @@ export class TreeViewComponent implements AfterViewInit, OnInit, OnDestroy {
 		if (!eventOnNode) {
 			return;
 		}
-		this.toggle.emit(eventOnNode.node)
+		this.toggle.emit(eventOnNode.node);
 	}
 
 	/**
@@ -200,7 +200,7 @@ export class TreeViewComponent implements AfterViewInit, OnInit, OnDestroy {
 		// making a recursive shallow copy to avoid performance issues when deeply cloning templateRefs if defined in the node
 		const copiedNode = Object.assign({}, node);
 		if (node.children) {
-		  copiedNode.children = node.children.map(child => this.copyNode(child));
+			copiedNode.children = node.children.map(child => this.copyNode(child));
 		}
 		return copiedNode;
 	}