Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fluid state for text area #3012

Merged

Conversation

eduardmarcinco
Copy link
Contributor

Closes #2891

A way of displaying skeleton was updated as now it needs to handle standard skeleton and fluid skeleton depending on the input property.

@eduardmarcinco eduardmarcinco requested a review from a team as a code owner September 25, 2024 09:29
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 981fb0b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/67009cadb52aa30008fffecc
😎 Deploy Preview https://deploy-preview-3012--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55
Copy link
Contributor

Akshat55 commented Oct 5, 2024

Removed cds--text-area--warn for the time being, want to avoid adding API that we may have trouble removing in future. Want to find a way we can streamline setting warning in ONLY the wrapper level instead of both the wrapper and the textarea. We can probably release this for now as experimental and come back to it.

@Akshat55 Akshat55 merged commit c42963f into carbon-design-system:master Oct 5, 2024
14 checks passed
Copy link

github-actions bot commented Oct 5, 2024

🎉 This PR is included in version 5.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coreset
Copy link

coreset commented Oct 18, 2024

HI @eduardmarcinco,
I’ve been working on issue #2886, which focuses on implementing a fluid state for the Date picker. While doing so, I came across your PR to better understand the patterns and practices followed in this repository.😊

In the process, I noticed that when changing the text area to a fluid variant in Storybook, the background of the label also changes. I just wanted to confirm— is this the intended behavior?
I also wanted to ask if there are any specific guidelines or rules I should follow when adding a new style class to this repository (excluding the carbon/style package).

@eduardmarcinco
Copy link
Contributor Author

hi @coreset ,
you can check Carbon React implementation here, to see how fluid state looks like -> https://react.carbondesignsystem.com/?path=/docs/experimental-fluid-components-unstable-fluiddatepicker--overview

Also check it's source code at https://github.com/carbon-design-system/carbon

Based on that you would know what classes to use in what scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fluid state for Text Area
3 participants