Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select-item): export class and style props #1840

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Nov 5, 2023

Fixes #1839

SelectItem is missing type definitions for the class and style props. Even though this defines props on the component, this is not a breaking change as the behavior has always been supported.

@metonym metonym changed the title fix(select-item): define class and style props fix(select-item): export class and style props Nov 5, 2023
Copy link
Collaborator

@theetrain theetrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I can ship this Monday evening, but if you get to it first then go ahead.

@metonym metonym merged commit a9460e9 into master Nov 8, 2023
1 check passed
@metonym metonym deleted the fix-select-types branch November 8, 2023 02:58
@metonym
Copy link
Collaborator Author

metonym commented Nov 8, 2023

Released in v0.81.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectItem properties style/class missing from types.
3 participants