Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(button): reduce stylesheet size #11223

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(button): reduce stylesheet size #11223

wants to merge 4 commits into from

Conversation

andy-blum
Copy link
Contributor

Related Ticket(s)

Closes #11219

Description

  • Moves button component styles from packages/styles to packages/web-components
  • Reduces excess @use statements in CWC button

Changelog

Changed

  • Reduced styles in c4d-button

@andy-blum andy-blum requested a review from a team as a code owner December 12, 2023 20:22
@andy-blum andy-blum requested review from emyarod and IgnacioBecerra and removed request for a team December 12, 2023 20:22
@andy-blum andy-blum changed the title Chore/remove react styles button chore(button): reduce stylesheet size Dec 12, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11223/index.html

Built with commit: df0835f2d82eb061e6b47a4a714881b69f34dd78

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11223/index.html

Built with commit: df0835f2d82eb061e6b47a4a714881b69f34dd78

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11223/index.html

Built with commit: df0835f2d82eb061e6b47a4a714881b69f34dd78

m4olivei
m4olivei approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

emyarod
emyarod approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11223/index.html

Built with commit: df0835f2d82eb061e6b47a4a714881b69f34dd78

@m4olivei m4olivei added the owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@m4olivei m4olivei m4olivei approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

button
5 participants
@andy-blum @ibmdotcom-bot @m4olivei @emyarod @kennylam