-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): reconfigure percy to only snapshot mobile in the white theme #14886
chore(ci): reconfigure percy to only snapshot mobile in the white theme #14886
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
We hit the snapshot limit before we could test this 😞 We'll have a new allotment on Monday to test this. |
Something's not right, Percy still shows 920 snapshots being used for this PR. I think we should be seeing a diff of some snapshots being deleted on this PR. |
Looking into this further, it appears the snapshot "count" in the percy dashboard does not reflect the true count of snapshots. Build #12923 is the most recent build on Meanwhile, a recent build from this PR shows the update made here to restrict that same snapshot to a single browser width: In both cases the total snapshot "count" for the build is 920. Based on this support article, browser widths do count as a snapshot each:
Overall this means we have no way to verify that the billed snapshots per build are less than before this change. |
c9ad02f
Closes #14779
Based on our discussion of ideas, this reconfigures percy so that components are only snapshotted at the mobile breakpoint in the white theme. Components snapshotted in g10, g90, and g100 will only snapshot at the default 1366 width.
Changelog
Changed
Testing / Reviewing
main
to test it, I'm not totally sure.