Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard Nav AVT test for ToggleTip #14916

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 16, 2023

Closes #14914

Added keyboard navigation to ToggleTip component.

Changelog

New

  • Added new file e2e/components/ToggleTip/ToggleTip-test.avt.e2e.js

Testing / Reviewing

  • Ensure the test pass.
  • Ensure that the expected navigation is covered.

@guidari guidari requested a review from a team as a code owner October 16, 2023 18:38
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 01ad1d4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65414aefb400dc00084b11e1
😎 Deploy Preview https://deploy-preview-14916--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 01ad1d4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/65414aef7668010008e08703
😎 Deploy Preview https://deploy-preview-14916--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@github-actions github-actions bot added this pull request to the merge queue Oct 30, 2023
@tay1orjones tay1orjones removed this pull request from the merge queue due to the queue being cleared Oct 31, 2023
@tay1orjones tay1orjones enabled auto-merge October 31, 2023 18:43
@tay1orjones tay1orjones added this pull request to the merge queue Oct 31, 2023
Merged via the queue into carbon-design-system:main with commit e30238b Oct 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keyboard Nav AVT test for ToggleTip
4 participants