-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): replaced SideNavMenuItem.js
-> SideNavMenuItem.tsx
component
#14996
feat(component): replaced SideNavMenuItem.js
-> SideNavMenuItem.tsx
component
#14996
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@alisonjoseph Thank you! 😇 |
57db818
This one no longer accepts props passable to the underlying |
@kubijo No it wasn't intentional. What do you think is a reasonable course of action? Modify the |
If the Link component already has types, I'd extend those or at least do |
Closes #13607
To add a new file
SideNavMenuItem.tsx
with it's corresponding types.Changelog
Changed
Testing / Reviewing
To verify the changes: