-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social card improvements #143
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Shane98c, i'm so glad to see this brought to completion 🎊 👏🏽 !! the cards look great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern generally looks good to me!
@Shane98c how were you thinking about rolling this out? It could be nice to test out the full integration before merging (i.e. to test performance). But I guess we could also merge this as-is and then make the layouts
+ build-cards
updates in subsequent PRs.
` | ||
|
||
// Write the metadata file | ||
fs.writeFileSync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a flag that once we have this change in blog
and research
, we should also update drafts
to share the same pattern!
Co-authored-by: Kata Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great to me!
Do we want to clean up the old card
metadata values so that we're consistently using the og route or leave that for a potential followup?
.gitignore
Outdated
cards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this now too!
return new ImageResponse(component, { | ||
...options, | ||
fonts, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So slick!
This PR is an attempt at using the @vercel/og library to generate OpenGraph images for our blog posts dynamically. Once merged, this will eliminate the need to manually run
npm run build-cards
plus uploading social cards to s3 when updating our blog, streamlining our maintenance process.dependencies: