Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates argument in load_regions utility from bool to region name #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates argument in load_regions utility from bool to region name #7

wants to merge 1 commit into from

Conversation

norlandrhagen
Copy link
Contributor

@norlandrhagen norlandrhagen commented Jan 6, 2025 •
edited
Loading

To Do:

  • We need to update the input cities list path for central Asian cities.

@norlandrhagen norlandrhagen requested a review from orianac January 6, 2025 23:22
norlandrhagen
norlandrhagen commented Jan 6, 2025
View reviewed changes
notebooks/utils.py
return regions_df
elif extension == 'central-asia':
extension_cities = pd.read_csv(
"s3://carbonplan-climate-impacts/extreme-heat-extension/v1.0/inputs/<_______TODO_____ADD_PATH_TO_CENTRAL_ASIAN_CITIES_______>.csv"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orianac once we get the list of cities for central Asia, we can update this line.

@norlandrhagen norlandrhagen mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orianac orianac Awaiting requested review from orianac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@norlandrhagen