Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refectorying: Used fmt.Errorf() instead of errors.New() #205

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

yj-yoo
Copy link
Contributor

@yj-yoo yj-yoo commented Apr 15, 2024

What type of PR is this?
/kind cleanup

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

- In the next article, we recommend fmt.Errorf() when errors require formatting and use errors.New() for static error messages.
(https://www.digitalocean.com/community/tutorials/how-to-add-extra-information-to-errors-in-go)

Signed-off-by: Youngjun <[email protected]>
@antmoveh
Copy link
Contributor

/lgmt

@antmoveh
Copy link
Contributor

/approve

@antmoveh antmoveh added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 14, 2024
@antmoveh antmoveh merged commit fdd5f9e into carina-io:main Jun 14, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants