-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bbolt as snapshot store #9
base: main
Are you sure you want to change the base?
Conversation
@tangyang9464 @closetool @sagilio please review |
Updated the changes. Please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Currently, we are using the file snapshot store, if we switch the bbolt as snapshot store, maybe this breaks user data, do you have idea to improve this? |
I'm not sure whether we can simply migrate file snapshots to bbolt, that is to read file snapshots and put key-value pairs into bbolt. |
This is a good idea, I think we can add a flag here, default to file snapshot, if the user switches the bbolt snapshot, we need to check whether the file snapshot exists, if true, we need to migrate the file snapshot to bbolt snapshot. |
I just added relevant code. |
…o bbolt when necessary
This PR is based on #7. Try to implement bbolt snapshot instead of file snapshot.