Merge #1050

1050: NO-TICKET: avoid panicking on handling get responses r=Fraser999 a=Fraser999 This PR removes a couple of `todo!`s which could allow a malformed or more likely malicious message to cause the node to panic. Co-authored-by: Fraser Hutchison <[email protected]>
casper-network · Mar 2, 2021 · b330606 · b330606
2 parents c90260e + 5e97621
commit b330606
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -127,7 +127,7 @@ lint:
 
 .PHONY: audit
 audit:
-	$(CARGO) audit --ignore RUSTSEC-2020-0123
+	$(CARGO) audit --ignore RUSTSEC-2020-0123 --ignore RUSTSEC-2020-0146
 
 .PHONY: build-docs-stable-rs
 build-docs-stable-rs: $(CRATES_WITH_DOCS_RS_MANIFEST_TABLE)

diff --git a/node/src/reactor/validator.rs b/node/src/reactor/validator.rs
@@ -755,10 +755,16 @@ impl reactor::Reactor for Reactor {
                                 responder: None,
                             })
                         }
-                        Tag::Block => todo!("Handle GET block response"),
-                        Tag::BlockByHeight => todo!("Handle GET BlockByHeight response"),
+                        Tag::Block => {
+                            warn!(%sender, "received get block response");
+                            return Effects::new();
+                        }
+                        Tag::BlockByHeight => {
+                            warn!(%sender, "received get block by height response");
+                            return Effects::new();
+                        }
                         Tag::GossipedAddress => {
-                            warn!("received get request for gossiped-address from {}", sender);
+                            warn!(%sender, "received get request for gossiped-address");
                             return Effects::new();
                         }
                     },