Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend config compliance to check limit of largest wasm lane #5059

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Amend config compliance to check limit of largest wasm lane #5059

merged 5 commits into from
Jan 21, 2025
+108 −6

Conversation

darthsiroftardis
Copy link
Contributor

CHANGELOG:

  • Fixed the config compliance check for Deploys to ensure the payment amount does not exceed the limit of the largest WASM lane

@darthsiroftardis darthsiroftardis self-assigned this Jan 14, 2025
EdHastingsCasperAssociation
EdHastingsCasperAssociation approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but I have questions about over all approach

@darthsiroftardis
Copy link
Contributor Author

bors r+

casperlabs-bors-ng bot added a commit that referenced this pull request Jan 20, 2025
@casperlabs-bors-ng @darthsiroftardis
Merge #5059
d49a78b 
5059: Amend config compliance to check limit of largest wasm lane r=darthsiroftardis a=darthsiroftardis

CHANGELOG:

- Fixed the config compliance check for Deploys to ensure the payment amount does not exceed the limit of the largest WASM lane


Co-authored-by: Karan Dhareshwar <[email protected]>
@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

Build failed:

@darthsiroftardis
Copy link
Contributor Author

bors r+

casperlabs-bors-ng bot added a commit that referenced this pull request Jan 21, 2025
@casperlabs-bors-ng @darthsiroftardis
Merge #5059
cd6a880 
5059: Amend config compliance to check limit of largest wasm lane r=darthsiroftardis a=darthsiroftardis

CHANGELOG:

- Fixed the config compliance check for Deploys to ensure the payment amount does not exceed the limit of the largest WASM lane


Co-authored-by: Karan Dhareshwar <[email protected]>
@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

Build failed:

@darthsiroftardis darthsiroftardis added the bug Something isn't working label Jan 21, 2025
@darthsiroftardis
Copy link
Contributor Author

bors r+

@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

Build succeeded:

@casperlabs-bors-ng casperlabs-bors-ng bot merged commit 415e3db into casper-network:dev Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdHastingsCasperAssociation EdHastingsCasperAssociation EdHastingsCasperAssociation approved these changes

@zajko zajko zajko approved these changes

Assignees

@darthsiroftardis darthsiroftardis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darthsiroftardis @zajko @EdHastingsCasperAssociation