Update sources, DOI and copyright link in PUDL #3004
Merged
+43
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
added
datapkg
zaneselvans
requested changes
Nov 2, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #3004 +/- ##
=====================================
Coverage 88.7% 88.7%
=====================================
Files 91 91
Lines 11007 11010 +3
=====================================
+ Hits 9766 9769 +3
Misses 1241 1241
☔ View full report in Codecov by Sentry. |
zaneselvans
approved these changes
Nov 2, 2023
src/pudl/metadata/classes.py
Outdated
| @@ -228,6 +228,7 @@ def __repr_args__(self) -> list[tuple[str, Any]]: | |||
|
|
|||
| HttpUrl = pydantic.AnyHttpUrl | |||
| """Http(s) URL.""" | |||
| """DOIs from Zenodo archives.""" | |||
There was a problem hiding this comment.
I think this docstring is a leftover?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to comments on #3000 and #3001 and the Zenodo migration in pudl-archiver PR #184 this PR makes some minor modifications to the way we write and read datapackages and source data metadata on the PUDL side. Specifically:
DOIfield with pydantic validation to the datapackage class, using regex from thepudl-archiverzenodo-rolefield to the contributors which defaults toproject member, and encodes the list of possible roles in the new Zenodo API (a newly required field).PR Checklist
dev).