-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename heat_rate_mmbtu_mwh -> unit_heat_rate_mmbtu_per_mwh
... again
#3029
Merged
bendnorman
merged 7 commits into
rename-core-assets
from
rename-heat-rate-mmbtu-mwh-column
Nov 16, 2023
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d61005d
Rename heat_rate_mmbtu_mwh -> heat_rate_mmbtu_mwh_by_unit
bendnorman 53e2f2d
Rename heat rate mmbtu mwh to follow existing naming convention
bendnorman d8c01da
Rename heat_rate_mmbtu_mwh_eia/ferc1 columns to unit_heat_rate_mmbtu_…
bendnorman afaa449
Remove unused ppe_cols_to_grab variable
bendnorman 0f90efa
Resolve migration issues with unit heat rate column
bendnorman f82b56e
Merge branch 'rename-core-assets' into rename-heat-rate-mmbtu-mwh-column
bendnorman 7ef9c70
Recreate heat rate migration revision
bendnorman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
113 changes: 0 additions & 113 deletions
113
migrations/versions/1ceb9897fd34_add_data_maturity_to_eia923m_tables.py
This file was deleted.
Oops, something went wrong.
35 changes: 0 additions & 35 deletions
35
migrations/versions/3313ca078f4e_demand_hourly_pa_ferc714_report_date_.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with there being several migration versions in here changing? Including older ones? Is this search-and-replace gone wild? It seems like the older migrations might actually need to refer to the older column name.
Alternatively, should we wipe all the migrations periodically to keep too many layers from building up? Since I don't think we actually intend for it to be possible to migrate between all database versions.