Skip to content

Commit

Permalink
Remove ContactsTable.relative_position_in_um.reference
Browse files Browse the repository at this point in the history
  • Loading branch information
rly committed Jul 22, 2024
1 parent 3151258 commit b8b29e2
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 26 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ classDiagram
--------------------------------------
id : VectorData[int]
relative_position_in_um : List[Tuple[float, float], Tuple[float, float, float]]
--> reference : str, optional
contact_id : VectorData[str], optional
shank_id : VectorData[str], optional
plane_axes : List[Tuple[int, int], Tuple[int, int, int]], optional
Expand Down
8 changes: 0 additions & 8 deletions spec/ndx-extracellular-channels.extensions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ groups:
- - null
- 3
doc: Relative position of the contact in micrometers, relative to `reference`.
attributes:
- name: reference
dtype: text
doc: Reference point for the relative position coordinates and information about
the coordinate system used, e.g., which direction is positive in the x direction
(first element), which direction is positive in the y direction (second element),
etc.
required: false
- name: contact_id
neurodata_type_inc: VectorData
dtype: text
Expand Down
5 changes: 0 additions & 5 deletions src/pynwb/tests/test_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,8 @@ def test_constructor_add_row(self):
height_in_um=10.0,
)

# TODO might be nice to put this on the constructor of ContactsTable as relative_position__reference
# without using a custom mapper
ct["relative_position_in_um"].reference = "The bottom tip of the probe"

assert ct.name == "ContactsTable"
assert ct.description == "Test contacts table"
assert ct["relative_position_in_um"].reference == "The bottom tip of the probe"

assert ct["relative_position_in_um"].data == [[10.0, 10.0], [20.0, 10.0]]
assert ct["shape"].data == ["circle", "square"]
Expand Down
12 changes: 0 additions & 12 deletions src/spec/create_extension_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,6 @@ def main():
dtype="float",
dims=[["num_contacts", "x, y"], ["num_contacts", "x, y, z"]],
shape=[[None, 2], [None, 3]],
attributes=[
NWBAttributeSpec(
name="reference",
doc=(
"Reference point for the relative position coordinates and information about the "
"coordinate system used, e.g., which direction is positive in the x direction "
"(first element), which direction is positive in the y direction (second element), etc."
),
dtype="text",
required=False,
)
],
),
NWBDatasetSpec(
name="contact_id", # id is already used by DynamicTable
Expand Down

0 comments on commit b8b29e2

Please sign in to comment.