Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Dailies #1113

Merged
merged 22 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/dailies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
python-versions: '["3.9", "3.10", "3.11", "3.12"]'
os-versions: '["ubuntu-latest", "macos-latest", "macos-13", "windows-latest"]'

run-daily-dev-tests:
uses: ./.github/workflows/dev-testing.yml
Expand All @@ -27,11 +30,16 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
with:
python-versions: '["3.9", "3.10", "3.11", "3.12"]'

run-daily-live-service-testing:
uses: ./.github/workflows/live-service-testing.yml
secrets:
DANDI_API_KEY: ${{ secrets.DANDI_API_KEY }}
with:
python-versions: '["3.9", "3.10", "3.11", "3.12"]'
os-versions: '["ubuntu-latest", "macos-latest", "macos-13", "windows-latest"]'

run-daily-neuroconv-docker-testing:
uses: ./.github/workflows/neuroconv_docker_testing.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/neuroconv_docker_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:

- name: Pull docker image
run: |
docker pull ghcr.io/catalystneuro/neuroconv:latest
docker pull ghcr.io/catalystneuro/neuroconv:v0.6.4
pauladkisson marked this conversation as resolved.
Show resolved Hide resolved
docker pull ghcr.io/catalystneuro/neuroconv:yaml_variable

- name: Run docker tests
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Deprecations

## Bug Fixes
* Fixed dailies [PR #1113](https://github.com/catalystneuro/neuroconv/pull/1113)

## Features
* Using in-house `GenericDataChunkIterator` [PR #1068](https://github.com/catalystneuro/neuroconv/pull/1068)
Expand Down
Loading